* Give witnesses their own fact error

Writing and using plugins for Version 5 and above.
Post Reply
User avatar
BakerJL75
Platinum
Posts: 39
Joined: 14 Dec 2020 11:29
Family Historian: V7

Give witnesses their own fact error

Post by BakerJL75 » 13 Jan 2021 18:47

I'm running the "Give Witnesses Their Own Facts Plugin". I get the following error:
Screenshot 2021-01-13 122917.png
Screenshot 2021-01-13 122917.png (32.41 KiB) Viewed 404 times
. My census records are custom census(family) facts with roles. I have looked at Charles Atkinson and the parent record and see no issues. I ran it with a different witnessed fact and it was fine.

Suggestions? I'd be glad to provide more information, but not quite sure what else to add.

As an aside, I'm convinced not to use witnesses in my census facts. But I do like the variation in sentences that you can get with roles. Opinions on witnessed facts in general?
Thanks,
Jackie

User avatar
ColeValleyGirl
Megastar
Posts: 2210
Joined: 28 Dec 2005 22:02
Family Historian: V7
Location: Cirencester, Gloucestershire
Contact:

Re: Give witnesses their own fact error

Post by ColeValleyGirl » 13 Jan 2021 19:04

Which version of the plugin are you running?

User avatar
BakerJL75
Platinum
Posts: 39
Joined: 14 Dec 2020 11:29
Family Historian: V7

Re: Give witnesses their own fact error

Post by BakerJL75 » 13 Jan 2021 19:18

1.3. Just downloaded and installed it today.
Thanks,
Jackie

User avatar
tatewise
Megastar
Posts: 20130
Joined: 25 May 2010 11:00
Family Historian: V6.2
Location: Torbay, Devon, UK
Contact:

Re: Give witnesses their own fact error

Post by tatewise » 13 Jan 2021 20:32

Sorry! That is a fault in the Plugin mishandling the new rich text formatted (_FMT) note text.

Let me investigate and publish an updated version.
Mike Tate ~ researching the Tate and Scott family history ~ tatewise ancestry

User avatar
tatewise
Megastar
Posts: 20130
Joined: 25 May 2010 11:00
Family Historian: V6.2
Location: Torbay, Devon, UK
Contact:

Re: Give witnesses their own fact error

Post by tatewise » 14 Jan 2021 13:21

This investigation has revealed several aspects of handling rich text and metafields that Plugin authors need to learn.
e.g.
KB Code Snippet Copy Child Branch Fields that says it is V7 compatible is definitely not!

Try the attached Give Witnesses Their Own Facts Version 1.3.1 Date 14 Jan 2021.

Formatted rich text Notes and Citation Metafields should now migrate to the Individual facts correctly.

If you give it a clean bill of health I will publish it as V1.4 in the Plugin Store.
Attachments
Give Witnesses Their Own Facts.fh_lua
Version 1.3.1 Date 14 Jan 2021
(16.33 KiB) Downloaded 6 times
Mike Tate ~ researching the Tate and Scott family history ~ tatewise ancestry

User avatar
BakerJL75
Platinum
Posts: 39
Joined: 14 Dec 2020 11:29
Family Historian: V7

Re: Give witnesses their own fact error

Post by BakerJL75 » 14 Jan 2021 14:57

It works great. Thank you! One thought, and it's personal preference. Other people may have different preferences. I like that you put a notation in the Note field as to if they were a principal or witness. But it would be nice if it were in privacy brackets as I print my notes. However, its easy enough to fix with Search and Replace, so no big deal. Just a thought.

Thanks,
Jackie
Thanks,
Jackie

User avatar
tatewise
Megastar
Posts: 20130
Joined: 25 May 2010 11:00
Family Historian: V6.2
Location: Torbay, Devon, UK
Contact:

Re: Give witnesses their own fact error

Post by tatewise » 14 Jan 2021 16:23

Try the attached Give Witnesses Their Own Facts Version 1.3.2 Date 14 Jan 2021.

This gives the option of enclosing the Witness Role in [[privacy]] brackets.
Which of the following alternative formats would you prefer?

I've used the neat format:
[[Witness Role: Informant]]
which leaves a blank line when the text is privatised.
Sometimes you might get this which leaves two blank lines:
Fact note text ...
[[Principal Role]]
[[Witness Role: Informant]]
Role note text ...

The alternative format is:
[[Witness Role: Informant
]]

which looks a bit odd but removes the blank line.
However, sometimes you might get this which removes both blank lines but looks odd:
Fact note text ...
[[Principal Role
]][[Witness Role: Informant
]]Role note text ...
Attachments
Give Witnesses Their Own Facts.fh_lua
Version 1.3.2 Date 14 Jan 2021
(16.78 KiB) Downloaded 6 times
Mike Tate ~ researching the Tate and Scott family history ~ tatewise ancestry

User avatar
BakerJL75
Platinum
Posts: 39
Joined: 14 Dec 2020 11:29
Family Historian: V7

Re: Give witnesses their own fact error

Post by BakerJL75 » 14 Jan 2021 22:46

I've made enough backups and projects to have myself confused. I got this plugin (1.3.2) to work once, and liked it. It seemed like it missed some of my census facts and roles but they are pretty messed up right now (too many similar facts and roles) and I may just be confused. I need to clean things up and then try again. So it may be a while before I permanently confirm it's doing what we want. I'm going to take a break for tonight and start fresh on this tomorrow afternoon. Then I'll get back to you.
Thanks,
Jackie

User avatar
tatewise
Megastar
Posts: 20130
Joined: 25 May 2010 11:00
Family Historian: V6.2
Location: Torbay, Devon, UK
Contact:

Re: Give witnesses their own fact error

Post by tatewise » 14 Jan 2021 23:05

You do know that Edit > Undo Plugin Updates will reverse the Plugin changes quickly as long as you don't close FH.
And then Edit > Redo Plugin Updates will put the Plugin changes back, so you can quickly compare the two.

Also remember, that File > Backup/Restore > Revert to Snapshot... is available.

It is generally advisable to perform these kinds of test in a COPY of your Project.
Mike Tate ~ researching the Tate and Scott family history ~ tatewise ancestry

User avatar
BakerJL75
Platinum
Posts: 39
Joined: 14 Dec 2020 11:29
Family Historian: V7

Re: Give witnesses their own fact error

Post by BakerJL75 » 15 Jan 2021 20:35

Got myself straightened out. I did know about reversing changes, etc. And I had a backup. The problem was I've been messing around for so long that I had a lot of backups from the same day, and it took a while to figure out which one was the one I wanted. Anyway, I figured it out and ran the plugin and it's working great. I had no other carriage returns in my other notes, so I used your search and replace plugin to get rid of the extra carriage returns, and just left the Role information in brackets for my reference.
Thanks,
Jackie

User avatar
tatewise
Megastar
Posts: 20130
Joined: 25 May 2010 11:00
Family Historian: V6.2
Location: Torbay, Devon, UK
Contact:

Re: Give witnesses their own fact error

Post by tatewise » 19 Jan 2021 11:56

Updated Give Witnesses Their Own Facts Version 1.4 Date 19 Jan 2021 is now in the Plugin Store.
Mike Tate ~ researching the Tate and Scott family history ~ tatewise ancestry

Post Reply