Page 1 of 1

Give witnesses their own fact error

Posted: 13 Jan 2021 18:47
by BakerJL75
I'm running the "Give Witnesses Their Own Facts Plugin". I get the following error:
Screenshot 2021-01-13 122917.png
Screenshot 2021-01-13 122917.png (32.41 KiB) Viewed 380 times
. My census records are custom census(family) facts with roles. I have looked at Charles Atkinson and the parent record and see no issues. I ran it with a different witnessed fact and it was fine.

Suggestions? I'd be glad to provide more information, but not quite sure what else to add.

As an aside, I'm convinced not to use witnesses in my census facts. But I do like the variation in sentences that you can get with roles. Opinions on witnessed facts in general?

Re: Give witnesses their own fact error

Posted: 13 Jan 2021 19:04
by ColeValleyGirl
Which version of the plugin are you running?

Re: Give witnesses their own fact error

Posted: 13 Jan 2021 19:18
by BakerJL75
1.3. Just downloaded and installed it today.

Re: Give witnesses their own fact error

Posted: 13 Jan 2021 20:32
by tatewise
Sorry! That is a fault in the Plugin mishandling the new rich text formatted (_FMT) note text.

Let me investigate and publish an updated version.

Re: Give witnesses their own fact error

Posted: 14 Jan 2021 13:21
by tatewise
This investigation has revealed several aspects of handling rich text and metafields that Plugin authors need to learn.
e.g.
KB Code Snippet Copy Child Branch Fields that says it is V7 compatible is definitely not!

Try the attached Give Witnesses Their Own Facts Version 1.3.1 Date 14 Jan 2021.

Formatted rich text Notes and Citation Metafields should now migrate to the Individual facts correctly.

If you give it a clean bill of health I will publish it as V1.4 in the Plugin Store.

Re: Give witnesses their own fact error

Posted: 14 Jan 2021 14:57
by BakerJL75
It works great. Thank you! One thought, and it's personal preference. Other people may have different preferences. I like that you put a notation in the Note field as to if they were a principal or witness. But it would be nice if it were in privacy brackets as I print my notes. However, its easy enough to fix with Search and Replace, so no big deal. Just a thought.

Thanks,
Jackie

Re: Give witnesses their own fact error

Posted: 14 Jan 2021 16:23
by tatewise
Try the attached Give Witnesses Their Own Facts Version 1.3.2 Date 14 Jan 2021.

This gives the option of enclosing the Witness Role in [[privacy]] brackets.
Which of the following alternative formats would you prefer?

I've used the neat format:
[[Witness Role: Informant]]
which leaves a blank line when the text is privatised.
Sometimes you might get this which leaves two blank lines:
Fact note text ...
[[Principal Role]]
[[Witness Role: Informant]]
Role note text ...

The alternative format is:
[[Witness Role: Informant
]]

which looks a bit odd but removes the blank line.
However, sometimes you might get this which removes both blank lines but looks odd:
Fact note text ...
[[Principal Role
]][[Witness Role: Informant
]]Role note text ...

Re: Give witnesses their own fact error

Posted: 14 Jan 2021 22:46
by BakerJL75
I've made enough backups and projects to have myself confused. I got this plugin (1.3.2) to work once, and liked it. It seemed like it missed some of my census facts and roles but they are pretty messed up right now (too many similar facts and roles) and I may just be confused. I need to clean things up and then try again. So it may be a while before I permanently confirm it's doing what we want. I'm going to take a break for tonight and start fresh on this tomorrow afternoon. Then I'll get back to you.

Re: Give witnesses their own fact error

Posted: 14 Jan 2021 23:05
by tatewise
You do know that Edit > Undo Plugin Updates will reverse the Plugin changes quickly as long as you don't close FH.
And then Edit > Redo Plugin Updates will put the Plugin changes back, so you can quickly compare the two.

Also remember, that File > Backup/Restore > Revert to Snapshot... is available.

It is generally advisable to perform these kinds of test in a COPY of your Project.

Re: Give witnesses their own fact error

Posted: 15 Jan 2021 20:35
by BakerJL75
Got myself straightened out. I did know about reversing changes, etc. And I had a backup. The problem was I've been messing around for so long that I had a lot of backups from the same day, and it took a while to figure out which one was the one I wanted. Anyway, I figured it out and ran the plugin and it's working great. I had no other carriage returns in my other notes, so I used your search and replace plugin to get rid of the extra carriage returns, and just left the Role information in brackets for my reference.

Re: Give witnesses their own fact error

Posted: 19 Jan 2021 11:56
by tatewise
Updated Give Witnesses Their Own Facts Version 1.4 Date 19 Jan 2021 is now in the Plugin Store.